-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node-package integration to build debs and rpms #145
Conversation
Through the effort to make smaller package, several changes to the code and dependent modules were done: - dependent modules updated; lager, mochiweb and getopt - some dependent modules removed; erlcql, velvet, casbench - deprecate R15 Andalso, there are some kludge to enable package install with node_package; - not using escriptize but just a proxy script installed - unnecessary directories like log, data created - unnecessary user and group named basho-bench created for this - not pinning dependent module versions yet
I'll add R scripts and goodies for graphing like priv/gp_latencies.sh after this merged. |
Kota, can you fix up the 02da072 to avoid touching the Cassandra drivers? |
@slfritchie Some dependent modules of Cassandra drivers (lz4) screwed up packaging, but I can do that. I just doubted that we really need Cassandra driver or not. |
I'll try it later! |
lz4 and snappy does not have any tags, and that had confused `git describe`. This version still have following problems: - Current directory set to /var/lib/basho_bench When dpkg-installed basho_bench try tor start, its current directory is set as somewhere like /var/lib/basho_bench/lib/basho_bench-*. That is where the basho_bench script runs `cd` inside, because just to load correct beam files to run whole basho_bench. The workaround is to just specify `-d` option with absolute path. - Currently basho_bench has limited number of example configs installed in /etc/basho_bench. It should be installed in other place like `/usr/share/basho_bench/examples` but node_package seems not supporting such installation other than manpages.
From my commit log: lz4 and snappy does not have any tags, and that had confused
|
Here, it's ready for review again. Just a kind reminder. |
Hi, sorry about the delay, Kota. Is the addition of the |
+1 to everything else. |
Node-package integration to build debs and rpms
Thank you for review :) |
Node package requires the latest version tagged on github, so I'd like to tag this as 0.10.0 once this is merged. The number comes from latest version number in
basho_bench.app.src
.